search

redpony / cdec

Decoder, aligner, and model optimizer for statistical machine translation and other structured prediction models based on (mostly) context-free formalisms
http://cdec-decoder.org/
Apache License 2.0
183 stars 77 forks source link

Confirm that cdec classes can be included in Apache Joshua (Incubating) v6.1 Release #94

Closed lewismc closed 7 years ago

lewismc commented 7 years ago

Hi @armatthews @redpony @amittai @mjdenkowski we (the Apache Joshua (incubating) podling project management committee) are currently VOTE'ing on our 4th iteration of what we hope to be the first official Apache release of Joshua 6.1 (Incubating). Within the release candidate review however, we've stumbled across an issue involving licensing of code which was taken from cdec. Specifically, the files are sentclient.cc and sentserver.cc. The issue is whether or not we can ship these files with the release. The crux of the issue is as follows

Both files are /* Copyright (c) 2001 by David Chiang. All rights reserved.*/

Just because these files were added to a repo that is under an Apache license 
(by someone other than the author I would note) doesn't automatically mean the 
original files were Apache licensed.

Perhaps the best thing to do is to reach to the author and ask for permission 
to use the files / clarify the license they are under?

Can someone please comment as to whether these files are licensed as Apache Licence v2.0 as would be indicated by LICENSE.txt? Thank you in advance.

redpony commented 7 years ago

No idea- ask David.

On Mon, 5 Jun 2017 at 10:26 pm, Lewis John McGibbney < notifications@github.com> wrote:

Hi @armatthews https://github.com/armatthews @redpony https://github.com/redpony @amittai https://github.com/amittai @mjdenkowski https://github.com/mjdenkowski we (the Apache Joshua (incubating) podling project management committee) are currently VOTE'ing http://www.mail-archive.com/general@incubator.apache.org/msg59639.html on our 4th iteration of what we hope to be the first official Apache release of Joshua 6.1 (Incubating). Within the release candidate review however, we've stumbled across an issue involving licensing of code http://www.mail-archive.com/general@incubator.apache.org/msg59966.html which was taken from cdec. Specifically, the files are sentclient.c https://github.com/redpony/cdec/blob/master/training/utils/sentclient.cc and sentserver.cc https://github.com/redpony/cdec/blob/master/training/utils/sentserver.cc. The issue is whether or not we can ship these files with the release. The crux of the issue is as follows

Both files are / Copyright (c) 2001 by David Chiang. All rights reserved./

Just because these files were added to a repo that is under an Apache license (by someone other than the author I would note) doesn't automatically mean the original files were Apache licensed.

Perhaps the best thing to do is to reach to the author and ask for permission to use the files / clarify the license they are under?

Can someone please comment as to whether these files are licensed as Apache Licence v2.0 as would be indicated by LICENSE.txt https://github.com/redpony/cdec/blob/master/LICENSE.txt? Thank you in advance.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/redpony/cdec/issues/94, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJbay4uANg1k2T3FiSFtPrj00I61j11ks5sBHKCgaJpZM4NwllE .

lewismc commented 7 years ago

@redpony can you please tag him here? Thank you

lewismc commented 7 years ago

@redpony sorry to be a PITA, can you please ping David here? Thank you kindly.

kpu commented 7 years ago

E-mail him? https://www.nd.edu/~dchiang/

lewismc commented 7 years ago

Thank you @kpu

kpu commented 7 years ago

Paging @davidweichiang

mjpost commented 7 years ago

@lewismc, these were included long ago not via cdec but via Adam Lopez (a former colleague). However, they aren't really used by anything, and can be safely removed if you don't hear from David.

davidweichiang commented 7 years ago

Oh wow, glad someone is using my code. :) Since these were written when I was a student, I believe (but have not checked) that I am indeed the copyright holder, not the University of Pennsylvania. If that's the case, I'd be happy to license them under the Apache license.

lewismc commented 7 years ago

Ok doke thank you for all the input.

lewismc commented 7 years ago

Is there any ways for this to be checked out? I know it may be a bit of a pain, but we would rather include them than remove at this stage. Thanks again.

davidweichiang commented 7 years ago

Sorry I'm not sure what you are asking -- whether I am the copyright holder?

On Jun 9, 2017, at 18:19, Lewis John McGibbney notifications@github.com wrote:

Is there any ways for this to be checked out? I know it may be a bit of a pain, but we would rather include them than remove at this stage. Thanks again.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

lewismc commented 7 years ago

Yes Sir

davidweichiang commented 7 years ago

As far as I can tell, this policy answers in the affirmative: http://provost.upenn.edu/policies/faculty-handbook/research-policies/iii-d

On Jun 9, 2017, at 19:12, Lewis John McGibbney notifications@github.com wrote:

Yes Sir

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

lewismc commented 7 years ago

Thank you very much @davidweichiang and others that participated here. Closing this as resolved.