Fix wrong commit in tree-table header

redrabbit / git.limo

A Git source code management tool powered by Elixir with easy installation & high extensibility.

https://git.limo

MIT License

497 stars 42 forks source link

Fix wrong commit in tree-table header #74

Closed redrabbit closed 3 years ago

redrabbit commented 4 years ago

Currently we use the most recent commit from GitRekt.GitAgent.tree_entries_by_path/3 and use it in the table header. But sometimes this is wrong for example when moving/deleting tree entries:

Instead of extracting the most recent commit from the tree table, we should either

~~make a second GitRekt.GitAgent.tree_entry_by_path/3 call.~~
find a way to match most recent commit for the given path directly without having to rely on the available tree entries.

redrabbit commented 3 years ago

Note that with 4a2107a this only occurs when tree_path is not empty (when browsing a subdirectories or viewing a file).

redrabbit commented 3 years ago

Commit 9cdcd26 fixed this issue.