search

redrabbit / git.limo

A Git source code management tool powered by Elixir with easy installation & high extensibility.
https://git.limo
MIT License
497 stars 42 forks source link

E-mail vaildation fails on accepting all current tlds #82

Closed florianb closed 3 years ago

florianb commented 3 years ago

Hi – your check for the maximum length (of 5) on tlds, at

https://github.com/almightycouch/gitgud/blob/13b822815a1b321dbe1a97e685c2c2ffe2e6beef/apps/gitgud/lib/gitgud/schemas/email.ex#L118

fails current top level domains in use.

You may also take a look at: https://stackoverflow.com/a/22038535/432696

redrabbit commented 3 years ago

Thanks @florianb ❤️

I've updated the regex to be less restrictive.

florianb commented 3 years ago

Fantastic – thank you very much!