redraskal / r6-dissect

Match Replay API/CLI for Rainbow Six: Siege's Dissect (.rec) format.
MIT License
67 stars 12 forks source link

Defuser Plant Time is fixed at 0:44 #102

Open Segergren opened 1 month ago

Segergren commented 1 month ago

Describe the bug The DefuserPlantComplete event consistently shows 44 seconds, regardless of the actual countdown time when the defuser was planted. To accurately calculate the round length, it would be ideal if this time reflected the exact moment the defuser was planted. For example, if the countdown timer is at 1:14 when the defuser is planted, the DefuserPlantComplete time should be 1:14, not 0:44. This might be related to #73.

Current behavior

{
    "type": {
        "name": "DefuserPlantComplete",
        "id": 3
    },
    "username": "Boost100hz",
    "time": "0:44",
    "timeInSeconds": 44
}

Expected behavior

{
    "type": {
        "name": "DefuserPlantComplete",
        "id": 3
    },
    "username": "Boost100hz",
    "time": "1:14",
    "timeInSeconds": 74
}

example.json


Thank you so much for making this project. I'm amazed! I'm currently working on implementing a feature to display kills and deaths in the open-source project RePlays (https://github.com/lulzsun/RePlays).

redraskal commented 1 month ago

I'll take a look at this

redraskal commented 3 weeks ago

defuser stuff is a little messed up like #48 right now. i'll probably look into that again and just rework it

redraskal commented 3 weeks ago

also related to #86