Operator Roles - Githubissues

stnokott commented 1 year ago

use go:generate to generate map[operator]role structure dynamically, allowing us to update the map without manually changing anything (given the Ubisoft page we are querying - https://www.ubisoft.com/de-de/game/rainbow-six/siege/game-info/operators - doesn't change its logic. If that happens, we can still manually update the map)
derive the team roles based on the chosen operators, i.e. if a player chooses a defender operator, we can safely set their team to "Defense"

Note that I kept the alliance field discussed in https://github.com/redraskal/r6-dissect/issues/26#issuecomment-1465327214. I figured you weren't certain yet that it can be removed.

(Messed up a bit in 3153003, so there's a bit of an ugly amend in 221c7f7)

Fixes #28 .

stnokott commented 1 year ago

Maybe run go:generate once to see if it works on your end too

stnokott commented 1 year ago

Also, might be worth adding go:generate ./... to the build job

redraskal commented 1 year ago

Also, might be worth adding go:generate ./... to the build job

We really only need to run this when something is manually added/removed. Going to need some tests soon enough with example replay files.

Maybe we could have a test to check if all operators have a role?

stnokott commented 1 year ago

We really only need to run this when something is manually added/removed. Going to need some tests soon enough with example replay files.

We also need to run it when a new season drops, i.e. when a new operator is added.

Maybe we could have a test to check if all operators have a role?

I'll add one

redraskal / r6-dissect