search

redraskal / r6-dissect

Match Replay API/CLI for Rainbow Six: Siege's Dissect (.rec) format.
MIT License
70 stars 11 forks source link

Simplify `Operator.Role` #37

Closed stnokott closed 1 year ago

stnokott commented 1 year ago

Simplifying Operator.Role to panic when unable to determine team role for an operator instead of returning an error. This is possible since we have a test in place verifying that each operator has a role assigned. The only scenario where the function can panic if it is called on unitialized an Operator (with value 0). Since we only use Operator.Role internally, we can assure this doesn't happen.

While at it, I also added ordering for the source code of operator roles in 42c5f9ef10. I was irritated that the generation of the operator roles map wasn't deterministic, making it hard to git diff the changes, i.e. when a new operator is added. This is now possible.

redraskal commented 1 year ago

Good idea on sorting the map! I noticed this as well