search

redraskal / r6-dissect

Match Replay API/CLI for Rainbow Six: Siege's Dissect (.rec) format.
MIT License
70 stars 11 forks source link

New Season Compatibility (r6-dissect-0.11.0) #52

Closed OAbbass closed 1 year ago

OAbbass commented 1 year ago

Describe the bug Executing the r6-dissect on replay files from Y8S2 with a json output will cause an error stopping the program from working

To Reproduce Steps to reproduce the behavior:

  1. Open a cmd line in r6-dissect directory
  2. Type in the cmd line enter "r6-dissect | path of your replay file | -x | output file name.json |" (without quotations)

Expected behavior A json file with the specified output name containing all the match details.

Additional context InkedCapture

No additional context.

hoxnets commented 1 year ago

I can confirm this happens for any type of operation. image image

KevinCCucumber commented 1 year ago

I can add to this:

panic: role unknown for operator ID 0

goroutine 1 [running]:
github.com/redraskal/r6-dissect/dissect.Operator.Role(...)
        /github/workspace/dissect/operator_roles.go:81
github.com/redraskal/r6-dissect/dissect.(*Reader).deriveTeamRoles(0xc0002bc200)
        /github/workspace/dissect/header.go:501 +0x459
github.com/redraskal/r6-dissect/dissect.(*Reader).readPlayer.func1()
        /github/workspace/dissect/player.go:21 +0x25
github.com/redraskal/r6-dissect/dissect.(*Reader).readPlayer(0xc0002bc200)
        /github/workspace/dissect/player.go:150 +0x1031
github.com/redraskal/r6-dissect/dissect.(*Reader).Read(0xc0002bc200)
        /github/workspace/dissect/reader.go:82 +0x19e
main.exportRound({0xc00007e180?, 0x12c512b?}, {0xc00000c0f0, 0xa})
        /github/workspace/main.go:153 +0xf0
main.main()
        /github/workspace/main.go:52 +0x2f2
redraskal commented 1 year ago

thank you for the comments, i'm working on fixing the remaining issues

redraskal commented 1 year ago

publishing a new release- should hopefully fix these issues

OAbbass commented 1 year ago

Can confirm the latest patch solved the issue.

OAbbass commented 1 year ago

I saw. Thanks again man. You've been huge man.

On Mon, Jun 12, 2023 at 9:36 PM Benjamin Ryan @.***> wrote:

Closed #52 https://github.com/redraskal/r6-dissect/issues/52 as completed.

— Reply to this email directly, view it on GitHub https://github.com/redraskal/r6-dissect/issues/52#event-9506277454, or unsubscribe https://github.com/notifications/unsubscribe-auth/API32GJBDPO2ZX4VAZDHVJDXK5OT5ANCNFSM6AAAAAAZBUI7TQ . You are receiving this because you authored the thread.Message ID: @.***>