redraskal / r6-dissect

Match Replay API/CLI for Rainbow Six: Siege's Dissect (.rec) format.
MIT License
70 stars 11 forks source link

Incorrect `matchFeedback` message in JSON output #89

Closed f870103 closed 8 months ago

f870103 commented 8 months ago

I'm encountering an issue with the matchFeedback field in the JSON output file generated by version v0.19.0 when using a Y9S1 replay file. The message property within matchFeedback objects contains unreadable characters like \ufffd\ufffd\ufffd\ufffd and \ufffd\ufffd\u0005\u0000.

"matchFeedback": [{
                    "type": {
                        "name": "Other",
                        "id": 10
                    },
                    "time": "0:00",
                    "timeInSeconds": 0,
                    "message": "\ufffd\ufffd\ufffd\ufffd"
                }, {
                    "type": {
                        "name": "Other",
                        "id": 10
                    },
                    "time": "0:00",
                    "timeInSeconds": 0,
                    "message": "\ufffd\ufffd\u0005\u0000"
                }, {
                    "type": {
                        "name": "Other",
                        "id": 10
                    },
                    "time": "2:59",
                    "timeInSeconds": 179,
                    "message": "\ufffd\ufffd\u0005\u0000"
                },

This issue has been observed on all my standard matches so far. I'm not sure if other match types are affected.

Match-2024-03-13_22-26-58-200-R01.zip Match-2024-03-13_22-26-58-200.json

redraskal commented 8 months ago

I think match feedback changed in Y9S1. For instance, I no longer see messages for locating the objective. This may have been migrated over to a more efficient binary format.

Right now, I am fixing the kill feed and will likely suppress other messages for now.

redraskal commented 8 months ago

The problem should be resolved in https://github.com/redraskal/r6-dissect/releases/tag/v0.19.1. Let me know if this is not the case!