redrock303 / Revisiting-Temporal-Alignment-for-Video-Restoration

69 stars 1 forks source link

Difficulties Running #9

Open itsagoodbrain opened 2 years ago

itsagoodbrain commented 2 years ago

I appreciate the code release, however, this was pretty difficult to get running. I managed to get there but the bar for the results was raised by the effort. I think it might be good to revisit a few things.

Here's things that I think would help others be able to use it

itsagoodbrain commented 2 years ago

I also found that there isn't a sequence_test.py for each model. I worked on creating my own for VDN but it seems the feed forward network requires the noise map and as best I can tell it is the generated noise. Is this correct?

redrock303 commented 2 years ago

I also found that there isn't a sequence_test.py for each model. I worked on creating my own for VDN but it seems the feed forward network requires the noise map and as best I can tell it is the generated noise. Is this correct?

Sorry for that. In fact, the noise map refers to the noise level, where all the elements have the same values (i.e. 20), As described in our paper, "In this task, we aim to remove Gaussian white noises with known noise levels".

itsagoodbrain commented 2 years ago

I see. Thanks for clarifying. I think I can manage. Would you like a PR with some changes to review or is my feedback here sufficient?

itsagoodbrain commented 2 years ago

And would it be possible to release the missing sequence_test.py for VDN? In the README it's the only one specified which isn't there in the repo.

redrock303 commented 2 years ago

I see. Thanks for clarifying. I think I can manage. Would you like a PR with some changes to review or is my feedback here sufficient?

I appreciate your PR. Thanks for your good suggestion, and I will upload this script soon.