redromnon / HeroicBashLauncher

Directly launch any Epic Games Store and GOG game from anywhere without Heroic on Linux.
GNU General Public License v3.0
354 stars 17 forks source link

[Feature Request] Option to not auto-add shortcuts to Steam on Steam Deck #104

Closed eskay993 closed 2 years ago

eskay993 commented 2 years ago

Is your feature request related to a problem? Please describe. While a useful option for most people to auto-add Steam shortcuts on Steam Deck, if you also use other programs to manage adding shortcuts to Steam (like Steam ROM Manager or Boilr) then you can end up with duplicates shortcuts on Steam Deck.

Describe the solution you'd like Would be great to have the ability to disable this functionality on Steam Deck so it behaves like desktop. This could possibly be added to settings.config as a true or false toggle (enabled by default as most people would probably want it on).

Could double up as a global settings so can toggle it on or off for any device/desktop (not just Steam Deck).

Thanks for your consideration.

redromnon commented 2 years ago

Sure, I can do that.

redromnon commented 2 years ago

Can you please check if this build works for you? - https://github.com/redromnon/HeroicBashLauncher/actions/runs/3091078701

I've added a setting called autoaddtosteam that can be set to false and prevent automatically adding games to Steam. Instead, it should create the AddToSteam.sh just like desktop.

redromnon commented 2 years ago

Adding to this, I've only kept this setting for Deck users for the time being.

eskay993 commented 2 years ago

Great thanks for this! Seems something is not quite right though.

First time I run it, it create a new settings.config as below and does not create a shortcut.

{
  "artwork": true,
  "epic": true,
  "gog": true,
  "autoaddtosteam": true
}

I then change it to "autoaddtosteam": false and it seems settings-config get overwritten with the default values above and it does create a shortcut.

Tried changing other settings, and they are overwritten as well. Seems the file is overwritten with the default values every time HBL is run.

Let me know if there is anything else you want me to test.

EDIT: Just to add, tested on a Steam Deck

redromnon commented 2 years ago

I'll fix this. The program first creates the file before reading it thus leading to overwriting.

redromnon commented 2 years ago

This commit should hopefully fix it - https://github.com/redromnon/HeroicBashLauncher/actions/runs/3099369845

eskay993 commented 2 years ago

Tested on Steam Deck and works great now!

Only minor thing, with "autoaddtosteam": false, the pop up still says games have been synced to Steam (even though they haven't). So might need an extra check there.

Thanks for implementing this so quickly.

redromnon commented 2 years ago

Great, I'll fix that message too.

redromnon commented 2 years ago

Feature included in v3.0.0