redromnon / HeroicBashLauncher

Directly launch any Epic Games Store and GOG game from anywhere without Heroic on Linux.
GNU General Public License v3.0
353 stars 17 forks source link

adding symlink support #118

Closed konsumer closed 1 year ago

konsumer commented 1 year ago

Related to #111

This does a different kind of check for the dir, so it will work with symlinks and stuff. I have the smallest steamdeck size, but a 1TB SD, so that's where I put things, and Heroic works fine with a sym-link from ~/Games/ to my SD, but not this script.

I can't seem to build it or even run it on steamdeck or in docker (my local machine is an intel mac) so you'll have to do the testing.

redromnon commented 1 year ago

@konsumer I've enabled the workflow for this PR. This means you can also test the new build yourself (as you add newer commits) by heading to GitHub Actions.

konsumer commented 1 year ago

The build from GH action seems to run, not sure why the pyinstaller executable built on my desktop or steamdeck would not. Something weird there.

Using that to test, I get an error that seems unrelated:

Traceback (most recent call last):
  File "func/HeroicBashLauncher.py", line 67, in <module>
  File "func/listinstalled.py", line 96, in listinstalled
  File "func/createlaunchfile.py", line 149, in createlaunchfile
FileNotFoundError: [Errno 2] No such file or directory: '/run/media/mmcblk0p1/Heroic/HeroicBashLauncher/GameFiles/Sable_Heroic.sh'
[4433] Failed to execute script 'HeroicBashLauncher' due to unhandled exception!

Since Heroic Launcher has a "add to steam" option now, that seems to work ok, I think I will just use that.

redromnon commented 1 year ago

@konsumer Are you still working on this PR?

konsumer commented 1 year ago

@konsumer Are you still working on this PR?

No, I am just using the feature built into Heroic Launcher, instead of this. I can take another look, if you need me to. Additionally, I had trouble getting it to build/run on my steamdeck. I can try testing with workflow builds.

redromnon commented 1 year ago

It's all up to you. You can close this PR if you've decided not to implement it.