search

redromnon / HeroicBashLauncher

Directly launch any Epic Games Store and GOG game from anywhere without Heroic on Linux.
GNU General Public License v3.0
354 stars 17 forks source link

Zenity clean up #42

Closed eresonance closed 1 year ago

eresonance commented 2 years ago

Hey, I wanted to run your stuff from a git checkout directly, as well as being able to run it from a ssh terminal instead of needing to be directly on the deck. Check these changes out, fairly minor but just cleanup the use of zenity.

eresonance commented 2 years ago

The diff is a bit hard to read, but the argparse stuff is totally backwards compatible. That's important since people will already have .sh scripts with a particular use of the HeroicBashLauncher.

The intent of the makefile is to just help with testing and get the paths correct for where the launcher exe should end up. I guess you can update it if you want to put a release script together (if you don't already have one). Don't include the makefile in your releases. Not a fan of make, at all, I need to learn how to use meson or something...

redromnon commented 2 years ago

I don't know how to work with makefiles myself, so I need to learn too.

I'll merge as soon as I test this PR locally and make sure it works fine.

eresonance commented 2 years ago

Sounds good, just use make from the root dir of the repo to build the launcher, it'll figure out if it needs to run from GameFiles or from the root dir.

redromnon commented 2 years ago

Although I haven't tested the program thoroughly, there are some minor fixes to be made. I'll be pointing them out below.

redromnon commented 2 years ago

You should add the --zenity parameter like ./HeroicBashLauncher --zenity "$game" on line 26 in steam.py since GUI users will be executing the AddToSteam file.

redromnon commented 1 year ago

Closing due to inactivity and #108