[Bug] Install script exits saying that it isn't in `~/Games/Heroic` when it is.

[javalsai]

I've read the Issues section in the Readme and the Flatpak/Steam-Deck guide.

Describe the bug Install script exits saying that it isn't in ~/Games/Heroic when it is.

To Reproduce (First Screenshot)

Expected behavior Begin installation

Screenshots

Details

• Platform: Desktop
• OS: Arch
• Heroic Version: heroic-games-launcher-bin 2.3.9-2 (from AUR)
• Bash Launcher Version: v2.8.0

Additional context I have my heroic directory placed in /opt/games/heroic/javalsai, but I tried two things:

• Creating a symlink (~/Games/Heroic -> /opt/games/heroic/javalsai)
• Creating and empty directory in ~/Games/Heroic

Both failed with the same error (in the screenshot I tried symlink method).

[redromnon]

Strange. HBL checks if the Games/Heroic/ path exists in the current directory (basically /home/username/Games/Heroic/HeroicBashLauncher) before proceeding and your case satisfies the condition.

[redromnon]

Can you directly click/run the HeroicBashLauncher executable via GUI?

[javalsai]

Thanks for the reply!!!

Can you directly click/run the HeroicBashLauncher executable via GUI?

It just fails showing a window with the second screenshot.

[javalsai]

I tried with the version 2.7.5 and it tells me that there is a newer version, that should mean that there passed the directory check, right???

[redromnon]

Yes, because there was no directory check implemented in that release.

[javalsai]

I found the problem. In this line: https://github.com/redromnon/HeroicBashLauncher/blob/1a923c99c0aa30a020b299c4a91bef8942003611/func/HeroicBashLauncher.py#L18 os.getcwd() doesn't return the user home directory, instead it returns the current directory, which in my case is ~/Games/Heroic/HeroicBashLauncher, this can be seen very easily in a python repl:

[redromnon]

Ah, that's because you have created a symlink if I'm not wrong.

[javalsai]

I think that it should be replaced with os.path.expanduser('~')

[redromnon]

Here's mine

[redromnon]

I think that it should be replaced with os.path.expanduser('~')

It returns /home/username. It should be part of os.getcwd() path for HBL to work.

[javalsai]

Here's mine

The script checks if there is a directory called Games/Heroic placed in os.getcwd (in your case it would be /home/redromnon/Games/Heroic/HeroicBashLauncher), but because /home/redromnon/Games/Heroic/HeroicBashLauncher/Games/Heroic does not exist it should fail

[redromnon]

Yes, the second path does not and should not exist.

[redromnon]

Since in my case os.getcwd returns /home/redromnon/Games/Heroic/HeroicBashLauncher, HBL checks if /Games/Heroic/ is present in that path, which it is. It does not append the path like /home/redromnon/Games/Heroic/HeroicBashLauncher/Games/Heroic

[redromnon]

I think that symlink is causing the issue.

[javalsai]

I think that symlink is causing the issue.

Probably, maybe this fixes it:

[redromnon]

That is correct. os.path.isdir() just checks if that dir is present. But the catch is, your current path [os.getcwd()] should match it when you are executing HBL. But instead, it's being redirected to /opt/games/heroic/javalsai/HeroicBashLauncher because of that symlink. This should not happen.

[javalsai]

If you tell me how to compile the project I can try it

[redromnon]

You can follow this - https://github.com/redromnon/HeroicBashLauncher#building-and-testing and change the dir check code accordingly to support your symlink. Or erase it if you wish to.