Factorio-safety errors for circuit components

[fabi321]

Logic components like the arithmetic combinator and the decider combinator only accept a certain combination of special signals (e.g. signal-each, signal-anything and signal-everything). If they are set wrong, it doesn't even import a string.

The allowed combinations of these signals is explained here for decider combinators, and arithmetic combinators only allow one each as input, and only allow an each as output if it has each as input.

consider the following

d = DeciderCombinator()
d.set_decider_conditions('signal-everything', '<', 1, 'signal-each') # not allowed
bp=Blueprint()
bp.entities.append(d)
bp.to_string() # -> 0eNp9kE1uhDAMhe/idWY0jKC0UW8yqlAAd7BEfpQ4qAjl7jWURRdVl35+/p7tDfo5Y4jkGPQGxGhB/9IULBgTeQf6/lrV7du9bZq6btoXBeiYmDCBfmzgjEWZHHGgEeNl8LYnZ9hHQQSfxLgzNvgCfbs2ClbQ1fVWFAzecfRz1+NkFhK/mE5KJ73xmEy7+kkxcZfo6cy812fkj3BBWXTlidxTEnkNe2uhyFnMR4wNJh4LaXiHIzex2c+uFPjMIf/DNsP0B7WU8wlr57LtUdBV+SjlG/FxdTg=

The generated blueprint fails to import in Factorio, but no warning has been raised.

[redruin1]

Good catch. I've changed the functionality of ArithmeticCombinator and DeciderCombinator to the following logic to match the game:

• Arithmetic Combinator:
  • If first_operand, second_operand, or output_signal are set to "signal-anything" or "signal-everything", an DraftsmanError is raised because these signals are prohibited in this combinator type.
  • Attempts to set both first_operand and second_operand to "signal-each" will result in a DraftsmanError.
  • If neither one of first_operand nor second_operand are set to "signal-each", attempting to set output_signal to "signal-each" will raise a DraftsmanError.
  • If the output_signal is "signal-each" and either of the two operands was unset from "signal-each", then "signal-each" cannot be an output_signal; it is reset to None and a DraftsmanWarning is issued.
• Decider Combinator:
  • If second_operand is set to any one of the pure virtual signals, then DraftsmanError is raised.
  • When setting output_signal, the signal is checked against a matrix of available signals (illustrated below) that a first_operand can have as an output_signal. If the new output signal lies outside this list, a DraftsmanError is raised.
  • When setting first_operand, the output_signal is checked against that same matrix. If the new first_signal's list now no longer contains the output_signal, we reset the output signal to None and issue a DraftsmanWarning.

Value of first_operand	Acceptable values for output_signal
All normal signals	All normal signals, "signal-everything"
"signal-everything"	All normal signals, "signal-everything"
"signal-anything"	All normal signals, "signal-everything", "signal-anything"
"signal-each"	All normal signals, "signal-each"

Note that "All normal signals" in this context also includes None, or no signal in these places. I've updated the docs as well to reflect these changes and document these special signals. This will be in version 0.9.5.

[fabi321]

I just wanted to correct your truth table, as it is not in line with what the wiki says, but after testing ingame, I realized, that the wiki is wrong. Heads up for actually checking it ingame.