search

redruin1 / factorio-draftsman

A complete, well-tested, and up-to-date module to manipulate Factorio blueprint strings. Compatible with mods.
MIT License
94 stars 17 forks source link

`OverlappingObjectsWarning` being issued when they should not #27

Closed redruin1 closed 2 years ago

redruin1 commented 2 years ago

There are a number of cases where OverlappingObjectsWarnings are issued to the user when they're not valid:

  1. When StraightRail or CurvedRail entities overlap other StraightRail or CurvedRail entities
  2. When RailSignals or RailChainSignals are placed next to a diagonal straight rail (the collision box is not rotated 45 degrees because currently we operate exclusively with AABBs)

Feel free to add more in the comments if you come across any.

elswindle commented 2 years ago

Any entity that is within the bounding box of the CurvedRail will throw the error despite being a valid location. This is similar to 2 since it is using an AABB collision box for a curved object.

redruin1 commented 2 years ago

Both CurvedRail and diagonally placed StraightRails now have correct collision boxes, so this should no longer be an issue. I think these were the only real offenders, so I'm going to tentatively close this issue, though if anyone finds more examples feel free to reopen.