Closed ca1f closed 1 year ago
Fixed; this is now:
{
Optional("playback_volume"): Use(float),
Optional("playback_globally"): bool,
Optional("allow_polyphony"): bool,
}
so when imported the value will be coerced to a float to keep things consistent. When I finish 2.0 hopefully schema will be replaced with something a little better. This will be in either version 1.0.5
or 2.0
, whichever comes first.
The following blueprint string causes draftman's blueprint string processing to fail:
traceback:
it seems that factorio uses a single
1
to denote a 100% volume setting in a programmable speaker in the blueprint json string:which in turn will be parsed by python's json implementation to a single
int
value and this fails the schema validation check in https://github.com/redruin1/factorio-draftsman/blob/7abe32f72f75ab6b5a18f81623762eebab85a363/draftsman/signatures.py#L244-L253