Closed ca1f closed 1 year ago
Somewhat impressed I missed this one, as this is rather obvious. This is now added to the correct schema so importing no longer fails. In addition, I added a is_on
attribute to ConstantCombinator
, which provides a dedicated place to set this variable. I contemplated adding it under the enable_disable
moniker, but I feel this is probably more clear:
combinator = ConstantCombinator()
combinator.is_on = False
assert combinator.is_on == False
assert "is_on" in combinator.control_behavior
combinator.is_on = True
assert combinator.is_on == True
assert "is_on" in combinator.control_behavior
combinator.is_on = None
assert combinator.is_on == None
assert "is_on" not in combinator.control_behavior
Test suite has also been adjusted to account for this change. This fix will be in 1.0.5
, which will likely be out this week unless you happen to find more bugs to fix.
Cool, thanks for your efforts, really nice library!
The following blueprint string causes draftman's blueprint string processing to fail:
which contains a single constant combiner:
traceback:
It seems like the "is_on" key is entirely missing from the schema.