search

redseiko / ComfyMods

Mod scripts for the Comfy Valheim server.
GNU General Public License v3.0
16 stars 19 forks source link

<Chatter> [Suggestion] Handling for Portal HUD Text Spam #12

Closed virtualbjorn closed 1 year ago

virtualbjorn commented 2 years ago

Would be nice to catch the Portal HUD Text Spam so it doesn't flood the chat window

redseiko commented 2 years ago

I just saw this (oops). Can you provide a screenshot of what you mean?

virtualbjorn commented 2 years ago

I think it has something to do with mods that modify portal text

redseiko commented 2 years ago

Can you provide a screenshot and steps to reproduce, otherwise I don't really know how to diagnose and handle this case.

virtualbjorn commented 2 years ago

image

Able to replicate with only OdinsQoL and Chatter installed.

virtualbjorn commented 2 years ago

I think it has something to do with this HoverText patch image

virtualbjorn commented 2 years ago

Added PR for this suggestion. https://github.com/redseiko/ComfyMods/pull/13

virtualbjorn commented 2 years ago

Would it be possible to have this reopened for [Enhancements] until your text-base filtering in the coming updates? @redseiko

redseiko commented 2 years ago

Re-opened. I've spent the last few days staring at my own code and wondering how I ever got this to even work in the first place. 😭

PaloAlo commented 2 years ago

the portal tag interferes in a big way when you have rare magic portal, odins qol, and chatter together. might even do it with just odins qol and chatter by themselves. odins qol uses hover text (i believe) and chatter starts spamming the portal tag from the screen non-stop to the chat window. lags a player down to about 5 fps when you go near a portal. i've already mentioned it to wackymole. and i think he mentioned it to azumatt. But for now i cant use your chatter mod because of the lag its causing. just thought you should be in the loop on this.

virtualbjorn commented 2 years ago

@PaloAlo , @redseiko is still looking into this one for better implementation as my PR didn't pass the tests, it does the job but still needs some more work to make it efficient

redseiko commented 1 year ago

Good news, I've made progress on implementing a CustomDrawer within ConfigurationManager to handle embedding a list-of-strings within a string value for BepInEx configuration.

chatter-text-filter

Still a WIP as I need to choose the correct delimiter as well as generalize the drawer for the other types of messages as well as actually implement the filtering itself.

redseiko commented 1 year ago

Finished this feature with the custom drawer and it's now available on Thunderstore as v1.2.0.

https://valheim.thunderstore.io/package/ComfyMods/Chatter/