redskap / swagger-brake

Swagger contract checker for breaking API changes
Apache License 2.0
58 stars 16 forks source link

Change in type of response attribute is not detected #24

Closed MinniArora closed 4 years ago

MinniArora commented 4 years ago

Changed response attribute id from integer to string, as below, and this failing change was not detected.

From: "Pet": { "type": "object", "required": [ "name", "photoUrls" ], "properties": { "id": { "type": "integer", "format": "int64" }, ......

To: "Pet": { "type": "object", "required": [ "name", "photoUrls" ], "properties": { "id": { "type": "string" }, .............................

galovics commented 4 years ago

Thanks @MinniArora. Will be fixed in the next release.

MinniArora commented 4 years ago

Thank you for a quick fix