search

redskap / swagger-brake

Swagger contract checker for breaking API changes
Apache License 2.0
57 stars 16 forks source link

Make parameter `old-api` take precedence over Maven settings #37

Closed vavvolo closed 3 years ago

vavvolo commented 3 years ago

The swagger brake Maven plugin sets default values for the groupId, artifactId, and currentVersion parameters. This causes an error when using the oldApi parameter from the Maven plugin. Rather than removing the default values from the Maven plugin and introducing breaking changes, this PR updates the logic in the core library. This should not introduce breaking changes because current users of the library use either the old-api param or the Maven settings.

vavvolo commented 3 years ago

@galovics if you think it's better to change the Maven plugin I'll open a PR in the other project to clean the default values when oldApi is provided.

galovics commented 3 years ago

@vavvolo thanks, I've merged this rather than changing the plugin. Let's aim for consistency in functionality instead of adding specific behavior to the plugins themselves.