Hide lock icon if OTR is set as "inactive"

redsolution / xabber-android

Open-source XMPP client for Android

http://xabber.com

Other

1.81k stars 814 forks source link

Hide lock icon if OTR is set as "inactive" #858

Open licaon-kter opened 5 years ago

licaon-kter commented 5 years ago

2.6(557)

Thanks

andrewnenakhov commented 5 years ago

But lock icon is used to enable OTR. If we hide it, users will be unable to enable it. Right?

licaon-kter commented 5 years ago

No, when inactive is set in Setttings, all OTR options are deactivated, grey, useless.

andrewnenakhov commented 5 years ago

Hm. indeed. Why would anyone choose disabled OTR mode? We've got too many options in settings, gotta shrink their numbers.

licaon-kter commented 5 years ago

You know that OTR has it's drawbacks (eg. no multi device), I'd happily advise users to disable it so I don't end up with ?OTR:AAMDJ+MVmSfjFZcAAAAAAQAAAAIAAADA1g5IjD1ZGLDVQEyCgCyn9hb messages on screen.

andrewnenakhov commented 5 years ago

@licaon-kter that won't help anyway if remote party will send you encrypted messages that you can't decrypt.

licaon-kter commented 5 years ago

No, I said that I advise them to "disable" it so we don't have mistakes. ;)