search

redspread / localkube

DEPRECRATED - See https://github.com/kubernetes/minikube
Apache License 2.0
184 stars 11 forks source link

Kubernetes service accounts support #50

Closed sercand closed 1 year ago

sercand commented 8 years ago

Localkube does not create service accounts at the beginning which causes problems when using kubernetes api with InClusterConfig. This pull request creates a PEM certificate at start and uses it as service account certificate.

ethernetdan commented 8 years ago

Hey @sercand - thanks for the PR!

@mfburnett and I are working on a process around external contributions with the goal of all changes going through the same standards (with exceptions for hotfixes and non-code changes). Hopefully this will get up within the next week.

luxas commented 8 years ago

We need this for core Kubernetes localkube

sercand commented 8 years ago

@ethernetdan any update on this

ethernetdan commented 8 years ago

@sercand could you rebase and group the standard library imports? Otherwise LGTM

In order to ensure the chain of title for the contribution back to Kubernetes core, I'll need you to sign a Redspread CLA. Is your github email the best place to reach you?

sercand commented 8 years ago

GitHub email is ok.

Sercan Değirmenci

2016-04-28 13:37 GMT+03:00 Dan Gillespie notifications@github.com:

@sercand https://github.com/sercand could you rebase and group the standard library imports? Otherwise LGTM

In order to ensure the chain of title for the contribution back to Kubernetes core, I'll need you to sign Redspread CLA. Is your github email the best place to reach you?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/redspread/localkube/pull/50#issuecomment-215381747

ethernetdan commented 8 years ago

Just sent

luxas commented 8 years ago

Should we retarget this one for minikube now?

ethernetdan commented 8 years ago

@luxas I think that's a good idea