redspread / spread

Docker to Kubernetes in one command
https://coreos.com
Apache License 2.0
1.84k stars 83 forks source link

Gitlab CI #159

Open clanstyles opened 8 years ago

clanstyles commented 8 years ago

I see support for Gitlab but I don't quite understand how you deploy it. Are we supposed to run spread on the actual node or setup the runner to deploy spread on bootstrap? The read me notates that we should set environment variables. Are we supposed to on the .gitlab-ci.yml? If we are, how do we set the cert file paths? Do we add them into the repos; that would be very insecure.

Thanks

chulkilee commented 8 years ago

My understanding is

clanstyles commented 8 years ago

My first concern, that doesn't seem too safe to have deployment credentials in your code base. I'm working on a fork. It also doesn't seem like deployment works all too well with spread. You also can't choose a namespace.

chulkilee commented 8 years ago

I haven't used this feature, but project variables seems to live in gitlab, not in source code, and will be injected to CI env.

ethernetdan commented 8 years ago

hey @clanstyles - thanks for bringing this up. Going to look into this over the next few days. sorry for the delayed response!

RobinVanCauter commented 8 years ago

You can indeed setup Variables for your project in Gitlab, so everything looks good on that part.

I do however seem to run into an issue because the spread command is initiated from the entrypoint instead of the Gitlab CI script section of my build. This takes away the possibility to do conditional deploys using trigger variables in Gitlab. It would be better to not actually run the command automatically and just let the user define it in the script section themselves.

chulkilee commented 8 years ago

I believe this issue can be closed - actually after renaming it into something like "GitLab CI - credentials management" to reflect the actual contents..

@T-Grave could you open another issue for that?