redstone-dart / redstone

A metadata driven microframework for Dart.
http://redstone-dart.github.io/redstone
MIT License
342 stars 42 forks source link

Don't parse body with certain methods. #167

Closed TheBosZ closed 8 years ago

TheBosZ commented 8 years ago

Fixes #131

Pacane commented 8 years ago

Thanks for the contribution! But would you mind adding a test for this case? I'm trying to add tests for everything I touch now.

Please :)

TheBosZ commented 8 years ago

I can't get it to error when I'm doing it in testing. Only when doing a real request. Have any ideas?

Pacane commented 8 years ago

Can you show me the code of your test?

TheBosZ commented 8 years ago

I just pushed my changes. I was testing the old behavior by just setting RequestParser._skipParseOnMethods to []

Pacane commented 8 years ago

Alright! Thanks for the contribution! :) I'll see to make a release off that.