redstone-dart / redstone

A metadata driven microframework for Dart.
http://redstone-dart.github.io/redstone
MIT License
342 stars 42 forks source link

Better deps handling #19

Closed vicb closed 8 years ago

vicb commented 10 years ago

The pubspec.yaml reads as follow

  di: ">=0.0.40 <2.0.0"
  stack_trace: ">=0.9.1 <2.0.0"

You can introduce a BC break by running a pub update because di and stack_trace can have a BC break. According to semver, the constraints should be:

luizmineo commented 10 years ago

Thanks for pointing me this out. These two packages have recently reached the 1.0 version, so I widened their constraints to allow the users to get the latest versions. According to their changelogs, there is no break changes between the pre-1.0 and 1.0 versions, but I will update the pubspec.yaml as soon as other core packages, like unittest and angular, updates their pubspec.yaml as well.

vicb commented 10 years ago

We haven't done a good job on using semver for di / route_hierarchical and it has caused troubles (I work for the angular.dart team and contribute to those).

In the future we will follow semver in a stricter way. You would save our users from troubles by doing

 di: ">=1.0.0 <2.0.0"
 stack_trace: ">=0.9.1 <0.10.0"
vicb commented 10 years ago

Sorry, my message is not very clear:

luizmineo commented 10 years ago

No worries. I understand your point and I agree with you. I plan to update the pubspec to follow the semver, and I just didn't it yet because there are some packages on pub that are still using the pre-1.0 versions, and I don't want to cause trouble to users that depends on them, neither prevent other users to update to the latest versions.

Pacane commented 8 years ago

Not a problem anymore.