search

redstreet / beancount_reds_importers

Simple ingesting tools for Beancount (plain text, double entry accounting software). More importantly, a framework to allow you to easily write your own importers.
GNU General Public License v3.0
115 stars 39 forks source link

PR Actions don't re-trigger when pushing new commits #114

Closed gary-roach closed 3 days ago

gary-roach commented 3 days ago

The pull request Actions run when creating the PR initially, but they don't re-run when you push a new commit to fix something found in the initial quality gate.

I think it's likely because the workflow definition doesn't have the type of "synchronize". This community issue states that it's necessary in order for actions to re-run when additional commits are pushed. They state that the edited type applies to changes to the title, body, state, base, etc... but not commits.

Is the intent for the actions to re-run if additional commits are pushed?

redstreet commented 3 days ago

Is the intent for the actions to re-run if additional commits are pushed?

Yes indeed. Thank you a bunch for catching this and finding the fix, much appreciated!

Committing in a second.