feat: Include unit price for investment transfers

redstreet / beancount_reds_importers

Simple ingesting tools for Beancount (plain text, double entry accounting software). More importantly, a framework to allow you to easily write your own importers.

GNU General Public License v3.0

115 stars 39 forks source link

feat: Include unit price for investment transfers #71

Closed m-d-brown closed 1 year ago

m-d-brown commented 1 year ago

This one is (hopefully!) much simpler to merge.

redstreet commented 1 year ago

Just to make sure I understand: aren't all three of the affected transactions in the test that are affected, transfers? If so:

shouldn't the other posting show up?
to be consistent, shouldn't they have the lot specification in the {XX USD} notation?

redstreet commented 1 year ago

Hi @m-d-brown , just checking to see if you are still inclined to complete this PR and merge? Thanks!

m-d-brown commented 1 year ago

Apologies! I forgot about this and haven't since touched the associated logic in my personal use of Beancount. I'll close the PR and will send another when I think through the change more completely.

redstreet commented 1 year ago

No worries at all, and sounds good! 👍