search

redstreet / beancount_reds_importers

Simple ingesting tools for Beancount (plain text, double entry accounting software). More importantly, a framework to allow you to easily write your own importers.
GNU General Public License v3.0
111 stars 38 forks source link

feat: add importer for Digital Credit Union #89

Closed hlieberman closed 10 months ago

hlieberman commented 10 months ago

This adds a CSV importer for Digital Federal Credit Union (DCU), the 18th largest credit union in the United States (by total assets under management). Unfortunately, DCU doesn't offer OFX exports, so this is the best we can do.

redstreet commented 10 months ago

Nice, thanks! For csv importers, it's far more important to have unit tests (compared to ofx), so would you mind adding at least a couple lines? It's simple: beancount_reds_importers/importers/schwab/tests/schwab_csv_checking is a good example.

hlieberman commented 10 months ago

Yeah, no problem. Would you mind if I pulled in another dependency, at least as dev dep? (I try, whenever possible, to add hypothesis tests if I'm going to write unit tests -- in addition to a static test.)

redstreet commented 10 months ago

Sure, dev dependencies are fine.

hlieberman commented 10 months ago

@redstreet, I ended up not using hypothesis after all. I wrote up a test, but it really is testing beancount more than it's testing the importer, since it's making sure a series of random transactions that balance before import, balance after import. Juice isn't really worth the squeeze.

redstreet commented 10 months ago

Makes sense, and sounds good. If you don't mind addressing the comment above about 'USD', I can merge this in.

hlieberman commented 10 months ago

the comment above about 'USD'

I'm sorry, I must be blind; I don't see anything about USD above. The only comment I see on the code is the ofx => csv one.

redstreet commented 10 months ago

I'm sorry, I must be blind; I don't see anything about USD above. The only comment I see on the code is the ofx => csv one.

Drat, completely my bad, sorry! Github requires separately hitting a "submit review" as a second step when adding a comment as a part of a review (as opposed to adding a freestanding comment). This is non-obvious and not at all the first time I've been tripped up by it. It should be visible now.

hlieberman commented 10 months ago

Drat, completely my bad, sorry! Github requires separately hitting a "submit review" as a second step when adding a comment as a part of a review (as opposed to adding a freestanding comment).

Ah yes, I've been bitten by this one myself a couple of times. Change made!

redstreet commented 10 months ago

Awesome, thank you!

redstreet commented 10 months ago

Merged