redsunservers / SuperZombieFortress

Custom Team Fortress 2 Gamemode, inspired from Left 4 Dead
GNU General Public License v3.0
36 stars 27 forks source link

[Feature request] Improvements to Admin Infected commands #159

Open Tiagoquix opened 5 months ago

Tiagoquix commented 5 months ago

Hello there.

Currently, when using the sm_tank command, it seems that the person who executed the commands is always chosen to be the tank if he or she is in the Zombies team.

I would like to request that the sm_tank command to choose a random Zombie player instead of choosing the person that executed the command.

Also, if possible, I would like to also request to add support for admins to force a player to be a tank with sm_tank <player name/#user ID>.

Thanks in advance.

FortyTwoFortyTwo commented 5 months ago

I would like to request that the sm_tank command to choose a random Zombie player instead of choosing the person that executed the command.

There is szf_zombietank command that exactly does that, but I do agree it's quite odd for sm_tank to function differently and is based on whoever executed it.

Also, if possible, I would like to also request to add support for admins to force a player to be a tank with sm_tank <player name/#user ID>.

sm_infected command works on tanks the same way as force setting someone an infected, command could be clarified a bit that it works on tank.

Tiagoquix commented 5 months ago

Hi there. I think we could do the following:

Which commands does what?

When used WITHOUT arguments:

When used WITH arguments:

Tiagoquix commented 5 months ago

By the way, I'm not entirely sure if this is already the case, but, if possible, I would like such messages from "Called tank." and other informative messages were visible only to those who executed the command, without making it visible to the players that there was administrative intervention.

From my limited knowledge of SourcePawn, having read the code, this behavior seems to already apply to "Called tank.", but I don't know if it applies to other commands (such as sm_rage and sm_stun).

Tiagoquix commented 5 months ago

Now I realize you mentioned "szf_zombietank", not "sm_zombietank". Reading the code, they are "server commands" rather than administrative commands. How does this differ in practice?

Mikusch commented 5 months ago

Means they can only be executed from server console (or done via sm_rcon). I don't think anyone really put much thought into these as they were mostly put in for development purposes

FortyTwoFortyTwo commented 5 months ago

sm_tank, when used with an argument consisting of a player name or user ID, will turn that player into a Tank in their next respawn.

It can be done, just that it'll only accept one user

By the way, I'm not entirely sure if this is already the case, but, if possible, I would like such messages from "Called tank." and other informative messages were visible only to those who executed the command, without making it visible to the players that there was administrative intervention.

It already only shows to whoever executes it, unless I'm missing some other commands.

From my limited knowledge of SourcePawn, having read the code, this behavior seems to already apply to "Called tank.", but I don't know if it applies to other commands (such as sm_rage and sm_stun).

Is there a reason to have one for rage if a global message were to be shown anyway?

Tiagoquix commented 5 months ago

It can be done, just that it'll only accept one user

Sure then!

It already only shows to whoever executes it, unless I'm missing some other commands.

I don't know if the other commands have a message too.

Is there a reason to have one for rage if a global message were to be shown anyway?

Maybe to differentiate from the timed one and the admin-forced one.