search

redsunservers / SuperZombieFortress

Custom Team Fortress 2 Gamemode, inspired from Left 4 Dead
GNU General Public License v3.0
36 stars 27 forks source link

Broken crash fix #77

Closed Kenzzer closed 4 years ago

Kenzzer commented 4 years ago

Moreover the move to dhook over a config file was unproperly done the argument was set as entity instead of int like it should have been, as mentioned in the PR above. I.e to pass a raw pointer.

This misport has probably prompted the commit mentioned as well.

Finally commit redsunservers/SuperZombieFortress@3073035178496d82f899d712f5d85b7db67ba348 introduced another mishap. Considering game_ui as a player/client. This error has also been corrected, fetching properly the client from the entity's datamap. (Not sure what this plugin function is even attempting)

Note: those changes haven't been tested, but should work

FortyTwoFortyTwo commented 4 years ago

I did some derps, but already fixed at this commit https://github.com/redsunservers/SuperZombieFortress/commit/4e1f73bd2560d6286dcbe43efab7db8d4b991798 before you sent a PR just minutes ago.

Though i missed a cbaseentity to int in gamedata, so just that should be needed to fully fix the whole thing.

Kenzzer commented 4 years ago

Solved the conflict, that PR also enforces coding style bouncing on PR #69. And might as well comment the code checking out the owner of game_ui, in case it's needed in the future for whatever reasons.