search

redsunservers / VSH-Rewrite

Popular Versus Saxton Hale gamemode remade from scratch
GNU General Public License v3.0
34 stars 25 forks source link

Add music volume compatibility to boss themes #379

Closed woisalreadytaken closed 1 year ago

woisalreadytaken commented 1 year ago

This PR allows players to adjust boss theme volume with TF2's music volume slider. Only applies to boss themes, so rage music and some song-voicelines like Demopan's win theme are unaffected.

Custom and future bosses will need to manually make use of the # prefix character and PrepareMusic when precaching sounds to be affected by this change.

FortyTwoFortyTwo commented 1 year ago

Can we just make it so that g_hTimerBossMusic automatically get # prefix when calling GetMusicInfo without needing to add one to each bosses with PrepareMusic?

woisalreadytaken commented 1 year ago

done, though with this change, custom bosses NEED to use PrepareMusic to get their theme to work at all