search

redth-org / BTProgressHUD

Port to Xamarin.iOS of the SVProgressHUD
Other
118 stars 64 forks source link

Enhancement suggestion #21

Closed dannycabrera closed 10 years ago

dannycabrera commented 10 years ago

Hey @nicwise , modified a few things and did not submit a pull request. Wanted your opinion on the enhancement. Basically added an extra parameter to ShowContinuousProgress that accepts a UIImage which is then displayed within the ring. Let me know your thoughts.

MakeButton("Show Continuous Progress with Image", () =>
{
       ProgressHUD.Shared.Ring.Color = UIColor.Green;
       ProgressHUD.Shared.ShowContinuousProgress("Continuous progress...", ProgressHUD.MaskType.None, 1000, UIImage.FromBundle("xamarin@2x.png"));
       KillAfter(3);
});



Preview:

showprogresswithimage

nicwise commented 10 years ago

Very nice. Please do a PR - I have another bug to fix in there most likely tomorrow, so I'll merge it at the same time.

Nic Wise t. +64 21 676 418 | @fastchicken b. http://www.fastchicken.co.nz/

On 14/04/2014, at 6:33, Danny Cabrera notifications@github.com wrote:

Hey @nicwise https://github.com/nicwise , modified a few things and did not submit a pull request. Wanted your opinion on the enhancement. Basically added an extra parameter to ShowContinuousProgress that accepts a UIImage which is then displayed within the ring. Let me know your thoughts.

MakeButton("Show Continuous Progress with Image", () => { ProgressHUD.Shared.Ring.Color = UIColor.Green; ProgressHUD.Shared.ShowContinuousProgress("Continuous progress...", ProgressHUD.MaskType.None, 1000, UIImage.FromBundle("xamarin@2x.png")); KillAfter(3); });

Preview:

[image: showprogresswithimage]https://cloud.githubusercontent.com/assets/1189224/2690287/606dde94-c339-11e3-8d1e-a58952953cd5.png

— Reply to this email directly or view it on GitHubhttps://github.com/nicwise/BTProgressHUD/issues/21 .

dannycabrera commented 10 years ago

PR sent, thanks Nic.