Closed patridge closed 5 years ago
👍 This would allow usage in Extensions
Closing this PR as it is super stale.
@patridge can you maybe outline the idea behind this PR? As far as I understand you want to allow it to show in a specific ViewController, rather than trying to find the current Window and adding it there?
Sorry, I definitely don't remember the specifics, and I don't even work where I fist had to make this hack work. I think I was having issues with multiple HUDs and/or across multiple ViewControllers. Or maybe it was when ViewControllers weren't full screen, like the extension example. I really have nothing left in my brain about this, so closing is fine.
Actually, seeing this line helped. https://github.com/redth-org/BTProgressHUD/pull/36/files#diff-94ddb517436bae64cf7f87eb485d3c15R859
// Make sure we account for parent size changing (e.g., TabBar/StatusBar auto-adjustments).
Maybe it was something as simple as limiting the HUD to the tab within a tab controller so that other tabs could still be used.
Show
methods.Show
calls with a parent and without a parent doesn't blow up the world.(Note: I wasn't sure where to send the PR, but this looked like the in-progress branch so I went for it. I can always cherry-pick it to a master-derived branch, though.)