search

redth-org / BTProgressHUD

Port to Xamarin.iOS of the SVProgressHUD
Other
118 stars 64 forks source link

Crashes on iOS 12 or older devices #74

Closed AyonAB closed 4 years ago

AyonAB commented 4 years ago

🐛 Bug Report

Crashes on older iOS devices because of the use of iOS Semantic Colors (SystemBackgroundColor, LabelColor etc.). There should be a checking of iOS version.

Objective-C exception thrown. Name: NSInvalidArgumentException Reason: +[UIColor systemBackgroundColor]: unrecognized selector sent to class 0x11ac07ec0

Reproduction steps

Update to latest version, use ProgesssHUD and run on any iOS 12 or below simulator or device

Configuration

Visual Studio for Mac Xamarin.iOS

Version: 1.3.0

Platform:

Cheesebaron commented 4 years ago

Ah! Sorry for that.

@AyonAB do you have time to fix it in a Pull Request?

AyonAB commented 4 years ago

Sure, can do that.

Cheesebaron commented 4 years ago

@AyonAB that would be much appreciated.

I guess we should check either if the selector is available or iOS version is met.

AyonAB commented 4 years ago

@Cheesebaron done. Review the PR when you can.

Cheesebaron commented 4 years ago

@AyonAB thanks! Will have a look!

Cheesebaron commented 4 years ago

I've made a new release 1.3.1 with your fix. Thanks again!