Added Support for MaskType in ShowImage

KevinvdBurg commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

MaskType were not supported With ShowImage

:arrow_heading_down: What is the current behavior?

ShowImage shows no MaskType

:new: What is the new behavior (if this is a feature change)?

MaskType is now supported in ShowImage

:boom: Does this PR introduce a breaking change?

ShowSuccessWithStatus, ShowErrorWithStatus and ShowImage needs to update there methods to include MaskType

:bug: Recommendations for testing

Start the Demo project and select the last button, It should have a MaskType.Black, change it in de code to ProgressHUD.MaskType.Gradient and see the magic ✨

:memo: Links to relevant issues/docs

:thinking: Checklist before submitting

✅ All projects build
✅ Follows style guide lines
✅ Relevant documentation was updated (not needed)
✅ Rebased onto current develop

Cheesebaron commented 3 years ago

I will have a look at this soon 😄

KevinvdBurg commented 3 years ago

Great! I have more ideas to make the code a bit cleaner and modern. Such as why is iOS 6 still supported 😅

Cheesebaron commented 3 years ago

Yeah, we could probably ditch a lot of the old support. You are welcome to contribute this.

Cheesebaron commented 3 years ago

@KevinvdBurg are you adding more PRs soon or is it OK I release a new version just with this?

KevinvdBurg commented 3 years ago

@Cheesebaron You can release this version. Dropping support for iOS6 wil probably need a major version code like 1.4

Cheesebaron commented 3 years ago

Cool I've pushed a new package: https://www.nuget.org/packages/BTProgressHUD/1.3.3

redth-org / BTProgressHUD