Closed KevinvdBurg closed 3 years ago
I will have a look at this soon 😄
Great! I have more ideas to make the code a bit cleaner and modern. Such as why is iOS 6 still supported 😅
Yeah, we could probably ditch a lot of the old support. You are welcome to contribute this.
@KevinvdBurg are you adding more PRs soon or is it OK I release a new version just with this?
@Cheesebaron You can release this version. Dropping support for iOS6 wil probably need a major version code like 1.4
Cool I've pushed a new package: https://www.nuget.org/packages/BTProgressHUD/1.3.3
:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
MaskType were not supported With
ShowImage
:arrow_heading_down: What is the current behavior?
ShowImage shows no MaskType
:new: What is the new behavior (if this is a feature change)?
MaskType is now supported in
ShowImage
:boom: Does this PR introduce a breaking change?
ShowSuccessWithStatus
,ShowErrorWithStatus
andShowImage
needs to update there methods to include MaskType:bug: Recommendations for testing
Start the Demo project and select the last button, It should have a MaskType.Black, change it in de code to ProgressHUD.MaskType.Gradient and see the magic ✨
:memo: Links to relevant issues/docs
:thinking: Checklist before submitting