Closed KevinvdBurg closed 3 years ago
Ah, the dreaded image issue. When you bundle images in a library, you need to tell where they can be found. This is what the BTProgressHud.targets
file are for. If you moved stuff around, you might need to adjust the paths there too.
See: https://github.com/redth-org/BTProgressHUD/blob/master/assets/BTProgressHud.targets
I will have a look and see what goes wrong with the images. At a glance, this PR looks good to me :)
Ah ok! I have a private nuget package and I solved it by using a Base64 string and converting that to an UIImage! 🎉 No more issues with loading from files!
@Cheesebaron if you want me to move all images to this Base64 format let me know, it wil make the whole image problem obsolete. Otherwise let me know I could test ShowSuccessWithStatus
, ShowErrorWithStatus
and ShowInfoWithStatus
. I'm not comfortable merging this PR without seeing it in action beforehand. 🙈
@Cheesebaron I convert the images to Base64 icons's and added the different image styles. I'm not gonna add extra features to this PR.
Can you check if every thing is working at your end, if so the version could be upped to 1.4
because there are some breaking changes
@KevinvdBurg thanks. Will have a look asap.
Still not 100% sure about the base64 images are a good way to embed images.
I 100% agree that it is not an ideal solution but it removes a lot of headaches trying to embed images in an Xamarin Nuget package.
I would rather have a custom BTProgressHUD xcassets so the images could be a vector and have a darkmode counterpart. But I have yet to find a solution for this
I've just given it a spin. Looks good to me. I've made the sample working on phones, we have so many buttons and it didn't scroll.
:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
ShowInfoWithStatus
Success
,Error
andInfo
BTProgressHUD
namespaceRemoved the ImageView size (24 x 24) use the size you wantIncrease the size to 32 * 32, but now it beter scales none square images:arrow_heading_down: What is the current behavior?
:new: What is the new behavior (if this is a feature change)?
ShowInfoWithStatus
Success
,Error
andInfo
Success
,Error
andInfo
(Outline or Outline Full):boom: Does this PR introduce a breaking change?
BTProgressHUD
namespace so theBigTed
is no longer used:bug: Recommendations for testing
Convent it to Base64 ImagesShowSuccessWithStatus
,ShowErrorWithStatus
andShowInfoWithStatus
because it couldn't load the images, can you explain this proces):memo: Links to relevant issues/docs
:thinking: Checklist before submitting