Enable Nullable attributes + cleanup - Githubissues

redth-org / BTProgressHUD

Port to Xamarin.iOS of the SVProgressHUD

Other

118 stars 64 forks source link

Enable Nullable attributes + cleanup #86

Closed Cheesebaron closed 2 years ago

Cheesebaron commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Feature + bugfix

:arrow_heading_down: What is the current behavior?

We don't have nullable attributes enabled and we have lots of big code blocks which are hard to read.

:new: What is the new behavior (if this is a feature change)?

Enables nullable attributes
Logic cleanup
Style cleanup

:boom: Does this PR introduce a breaking change?

Potentially

:bug: Recommendations for testing

:memo: Links to relevant issues/docs

:thinking: Checklist before submitting

[x] All projects build
[ ] Follows style guide lines
[ ] Relevant documentation was updated