reducejs / gulp.spritesmith-multi

A wrapper for gulp.spritesmith to generate multiple sprites and stylesheets.
17 stars 7 forks source link

No task end if folder is empty #2

Closed andrey-hohlov closed 8 years ago

andrey-hohlov commented 8 years ago

Hi!

I have this file structure:

├── sprites
│   ├── sprite-1
│   │   └── image1.png
│   │   └── image2.png 
│   ├── sprite-2
│   │   └── image1.png
│   │   └── image2.png 

If there is no files in both folders, like a

├── sprites
│   ├── sprite-1
│   │   └── empty
│   ├── sprite-2
│   │   └── empty

Task not ended:

[14:37:09] Starting 'sprite'...
Process finished with exit code 0

It's breaks runSequence for example.

zoubin commented 8 years ago

@andrey-hohlov Thank you for reporting this! Did you happen to continue the pipeline as https://github.com/zoubin/gulp.spritesmith-multi#continuing-the-pipeline? There is a bug in cases where no images found. I'm going to fix it today.

However, if you use it like https://github.com/zoubin/gulp.spritesmith-multi#example, empty directories should not cause the gulp task pending.

andrey-hohlov commented 8 years ago

@zoubin my task like as your example: https://github.com/zoubin/gulp.spritesmith-multi#continuing-the-pipeline because i need save images and styles into differet directories.

Waiting for you fix, it's really good module for me)

zoubin commented 8 years ago

@andrey-hohlov The fix is published in the release v2.2.1. If anything goes wrong, please tell me.

andrey-hohlov commented 8 years ago

It works, thank you!