search

reducktion / socrates

PHP package to Validate and Extract information from National Identification Numbers.
MIT License
47 stars 4 forks source link

Add native DateTime support and deprecate the old getDateOfBirth method #109

Closed AlexOlival closed 3 years ago

AlexOlival commented 3 years ago

This PR resolves #106 As discussed in the issue, we are sunsetting Carbon in an upcoming release of Socrates. Until then, a temporary getDateOfBirthNative() method was added that returns a vanilla PHP DateTime instance, and the old getDateOfBirth() method has been marked as deprecated.

Additionally, tests were written to make sure we support both Carbon and DateTime instances. I also threw in some minor improvements to some extractors and validators.