search

reducktion / socrates

PHP package to Validate and Extract information from National Identification Numbers.
MIT License
47 stars 4 forks source link

feat: Mexican ID Validator #78

Closed tiagomichaelsousa closed 3 years ago

tiagomichaelsousa commented 3 years ago

This PR will allow the validation for the Mexican identification number, aka CURP.

All the information to write the validators can be found here.

If you guys have any suggestions feel free.

Feat from: #71

More info about CURP:

tiagomichaelsousa commented 3 years ago

Looking good so far! Just two minor things on the validator and I think we're ok there. Do you mind also implementing an extractor, given that this ID encodes personal information?

Sure 🙂

AlexOlival commented 3 years ago

I have fixed the branch name because it was erroneously targetting a tag. Please change the merge target to release-1.3.0

tiagomichaelsousa commented 3 years ago

I have fixed the branch name because it was erroneously targetting a tag. Please change the merge target to release-1.3.0

I think everything is okay now! If not, please let me know 🙂

tiagomichaelsousa commented 3 years ago

Final little touches

Fixed 🙂

AlexOlival commented 3 years ago

Will merge asap when I'm back on the computer to call in the contributor bot

AlexOlival commented 3 years ago

Cheers @tiagomichaelsousa 🙏 I might tweak the validator a little bit to make it more inline with the other classes, but that'll come later

@all-contributors please add @tiagomichaelsousa for code and documentation

allcontributors[bot] commented 3 years ago

@AlexOlival

I've put up a pull request to add @tiagomichaelsousa! :tada: