search

reducktion / socrates

PHP package to Validate and Extract information from National Identification Numbers.
MIT License
47 stars 4 forks source link

Added Chile ID (RUT) validator #81

Closed gheleri closed 3 years ago

gheleri commented 3 years ago

resolve #79 It includes the validator itself and unit tests. The algorithm was based on wikipedia info.

AlexOlival commented 3 years ago

You'll have to fix the conflicts. We're now namespacing by continent, so make sure to get those right!

gheleri commented 3 years ago

Should I namespace as Latin America or Central/South America? Latin America seems easiest

gheleri commented 3 years ago

Please check now

AlexOlival commented 3 years ago

I think Geography makes more sense here, so SouthAmerica 👍

gheleri commented 3 years ago

It's done, mate! I will fix the another PR when this one will be ok

AlexOlival commented 3 years ago

Looking good on my end :+1: Just needs @JoaoFSCruz to take a look

AlexOlival commented 3 years ago

I have fixed the branch name because it was erroneously targetting a tag. Please change the merge target to release-1.3.0

gheleri commented 3 years ago

Done. I already changed the target to release-1.3.0 and add the codeblocks for Brazil, Chile and others minor fixes. However I did not add the code block for other European countries that do not yet have that (I realized it is necessary to add it when there are comments)

AlexOlival commented 3 years ago

Valeu @gheleri! 😁 @all-contributors please add @gheleri for code and documentation

allcontributors[bot] commented 3 years ago

@AlexOlival

I've put up a pull request to add @gheleri! :tada: