Closed gheleri closed 3 years ago
You'll have to fix the conflicts. We're now namespacing by continent, so make sure to get those right!
Should I namespace as Latin America or Central/South America? Latin America seems easiest
Please check now
I think Geography makes more sense here, so SouthAmerica 👍
It's done, mate! I will fix the another PR when this one will be ok
Looking good on my end :+1: Just needs @JoaoFSCruz to take a look
I have fixed the branch name because it was erroneously targetting a tag. Please change the merge target to release-1.3.0
Done. I already changed the target to release-1.3.0 and add the codeblocks for Brazil, Chile and others minor fixes. However I did not add the code block for other European countries that do not yet have that (I realized it is necessary to add it when there are comments)
Valeu @gheleri! 😁 @all-contributors please add @gheleri for code and documentation
@AlexOlival
I've put up a pull request to add @gheleri! :tada:
resolve #79 It includes the validator itself and unit tests. The algorithm was based on wikipedia info.