search

reducktion / socrates

PHP package to Validate and Extract information from National Identification Numbers.
MIT License
47 stars 4 forks source link

Feature/make classes abstract #88

Closed bofalke closed 3 years ago

bofalke commented 3 years ago

Closes #85

I stumbled upon this awesome project during the Hacktoberfest. It would be great if you could label this PR according to their recent update

AlexOlival commented 3 years ago

Hi @bofalke, thank you for your contribution! As stated by Digital Ocean in that link:

Submitted in a public repo AND ( The PR is labelled as hacktoberfest-accepted by a maintainer OR Submitted in a repo with the hacktoberfest topic AND ( The PR is merged OR The PR has been approved )

This repository already has the "hacktoberfest" topic, so it counts :smiley: worry not

AlexOlival commented 3 years ago

I have fixed the branch name because it was erroneously targetting a tag. Please change the merge target to release-1.3.0

AlexOlival commented 3 years ago

@bofalke no need for those classes to be declared final too, remove that please :+1: You gave me some ideas on how we should improve the contributing guidelines to have these sorts of things explained. Better than to then have to look out for IDE and editor default :grin:

bofalke commented 3 years ago

Updated the classes to not be final

AlexOlival commented 3 years ago

@all-contributors please add @bofalke for code

Thank you very much!

allcontributors[bot] commented 3 years ago

@AlexOlival

I've put up a pull request to add @bofalke! :tada: