search

reduf / search

GUI built on ripgrep for recursive file content searching.
MIT License
48 stars 5 forks source link

Override (glob pattern) are compared a a path, not on the file names #13

Closed reduf closed 1 year ago

reduf commented 1 year ago

The way OverrideBuilder (from ignore crate) currently works, is that it matches an arbitrary amount of globs relative to a specified path. Usually, when using ripgrep, this relative path is your working directory, which make a lot of sense.

In a GUI application, there isn't an obvious path, especially if multiple paths are used.

Ideally, I would want the glob patterns to match only the file name.

reduf commented 1 year ago

After quite some usage, matching just the file name wouldn't be ideal. I found it quite useful to be able to ignore all path. I'll close this issue for now, though I don't know if the way matches are done could be confusing.