search

redux-offline / tools

MIT License
5 stars 3 forks source link

Smart Queue: merging strategy, expose merge function #4

Open sorodrigo opened 5 years ago

sorodrigo commented 5 years ago

Hello, just want to reboot our smart-queue merging strategy conversation. (Original thread https://github.com/redux-offline/queue/issues/4)

We're almost there! And I feel bad because @prsn @echoes221 have devoted so much time into this and it's still not out there. If I'm right the only remaining issue is the merging strategy, we set to define a merging convention and to expose the merge fn. Right?

calumpeak commented 5 years ago

The first chance I had to take a look at this was a few days ago. I pushed up a branch and still have a few to-dos on it https://github.com/redux-offline/tools/tree/squashV2?files=1. I fixed a few inconsistencies (there were some immutable issues, adding new items and made the approach a little more declarative, and cleaned up the file into clear separation of concerns).

I'm going to curry the enqueue function so that it can accept a config for merging etc. I need to fix the original merge stategy also. I've gotta go through and fix the tests/add type Def's also.