search

reduxframework / redux-framework-4

Redux v4
https://redux.io/redux-4/
Other
97 stars 32 forks source link

Metabox Lite saving issue when Custom Fields visible - WP5 with Gutenberg #24

Closed STV11C closed 4 years ago

STV11C commented 5 years ago

Support Hash

https://support.redux.io/?id=7X91%2FP605ikM1%2Bc0E5l6iLSR%2FLZqcW%2B%2Bbu2YIfVOGak8%2FzaOUycs7RhrZGSSUZewtmNGhEfPh%2FnYhV9DGAQ%2BZA%3D%3D

Steps to reproduce

Add a Metabox Lite radio option. Enable 'Custom Fields' in Page/Post edit view (in WP5 using Gutenberg). Save the MBL option. After save and while on the page still, save the page again. You'll notice because the 'Custom Fields' was visible (which displays the Redux MBL options) they do not update on Save, so if you save again before refreshing the page, then your Redux MBL option will be overwritten by the previous settings.

Expected Behavior

Custom Fields (if visible) should update the Redux MBL value on Save.

Actual Behavior

Custom Fields (if visible) does not update the Redux MBL value on Save.

Any Error Details (PHP/JavaScript)

No errors.

redux-mbl-issue

dovy commented 5 years ago

Wow, interesting. Any chance you would be willing to send me your code (I won't keep anything) so I can debug it directly? That would help. dovy@redux.io. Thanks!

STV11C commented 5 years ago

Hi Dovy, I'll email you my MBL options now. Thanks.

STV11C commented 5 years ago

Hi Dovy, just touching base about this issue and if you received my email? Thanks!

dovy commented 5 years ago

I did, and I see what you mean. So the updates do occur in the DB, but they do not save on the "page". The issue is that the data may be varied from sterilized to just a string. It's something I can add as a feature request, but it won't impact anything really. The data still saves. I'm going to add this to a future feature enhancement. Metaboxes has worked for a while without this.

Do you have a particular use case as to why this is concerning?

STV11C commented 5 years ago

Hey Dovy, thanks for getting back to me. The reason it needs to be fixed is that any user (especially non-devs) who has the 'Custom Fields' visible (whether on purpose or by accident) will most probably experience what I did and not know why their options are constantly switching. I was perplexed for weeks about what was going on, and finally worked it out by chance. Cheers

dovy commented 5 years ago

Yea, I agree it's a feature we could add. I'll put it on the task list. Thank you for giving me what I needed to try it out.

STV11C commented 5 years ago

Awesome thanks!

kprovance commented 4 years ago

Metabox Lite has been removed. Moving to Pro issue tracker for eval.