search

reduxframework / redux-framework

Redux is a simple, truly extensible options framework for WordPress themes and plugins!
http://redux.io
Other
1.73k stars 582 forks source link

WordPress Plugin Repo rejected my plugin for redux #2591

Closed Mina88 closed 9 years ago

Mina88 commented 9 years ago

Hello, After submitted it on WordPress they sent me following message. Pls help me how can i overcame this.

"There are issues with your plugin code. Please read this ENTIRE email, address all listed issues, and reply to this email with your corrected code attached. It is required for you to read and reply to these emails, and failure to do so will result in your plugin being rejected.

Including another plugin

You have redux core included in your plugin

We cannot accept a plugin that includes an entire other plugin, wholesale, inside it.

While we understand the use of framework (or boilerplate) plugins, and encourage the use of common libraries, full blown plugins should never be included inside another, as it causes multiple potential issues, such as function/attribute conflicts, and also opens your code up for issues should the included plugin be closed for a security hole.

The proper way to include another plugin would be to require it in your own. You can use the hook is_plugin_active() to check to see if the plugin is, indeed, installed and active.

https://codex.wordpress.org/Function_Reference/is_plugin_active

The other alternative would be to actually fork the code, and not have a 100% copy in yours. Sadly, WordPress plugins don't have the ability to do sub-modules, so you'll have to actually customize the code for interaction."

kprovance commented 9 years ago

Asked and answered in #2289 :)

Mina88 commented 9 years ago

Thanks sir i am trying it. If i face any problem, can i tell you again.

kprovance commented 9 years ago

You can, but all I can do it tell you the same thing. Those are WP.org's rules, not ours. There isn't anything we can do about it.

dovy commented 9 years ago

The main thing is, don't include anything but the ReduxCore folder or you'll be instantly rejected. "Plugins can't contain other plugins."

Mina88 commented 9 years ago

I have added only reduxcore folder in my plugin. In reduxcore folder i inlcluded sample-config.php file also. It's rejected. can i use TGM to my plugin or has another way?

dovy commented 9 years ago

It shouldn't be rejected for using a framework. Try to talk some sense into them.

If not, TGM will work. :)