search

reduxjs / react-redux

Official React bindings for Redux
https://react-redux.js.org
MIT License
23.37k stars 3.37k forks source link

Dark theme for React Redux website. #1603

Closed KariNarhi closed 4 years ago

KariNarhi commented 4 years ago

Dark Theme for React Redux documents website.

I'd like to suggest implementing a Dark theme toggle switch for https://react-redux.js.org/ , the same way Redux website https://redux.js.org/ and Redux Toolkit website https://redux-toolkit.js.org/ have that small toggle switch at the right upper corner of the top navbar.

React Redux website navbar, with no theme toggle: ReactRedux

Redux website navbar, with a theme toggle: Redux

Redux Toolkit navbar, with a theme toggle: ReduxToolkit

It really hurts your eyes when you read other Redux documents with dark theme and suddenly React Redux website is bright white.

markerikson commented 4 years ago

This is dependent on migrating the React-Redux docs to use Docusaurus v2. The Redux and RTK sites have been migrated, but we haven't yet done the React-Redux site, largely because the versioning aspect makes it more complex.

If someone would like to tackle doing the migration, that would be appreciated.

Reflex-Gravity commented 4 years ago

Can I take this? I'll try to migrate it to v2.

markerikson commented 4 years ago

@Reflex-Gravity Sure, go for it! Please use the existing Redux and RTK docs sites as a baseline.

Reflex-Gravity commented 4 years ago

Sure, thanks.

ruppysuppy commented 4 years ago

I would like to work on this issue, but I have not worked with Docusaurus and am facing a few problems to get it up and running (was unable to trigger onClick event in react and was unable to figure out where to modify the header from). I was planning to add the dark mode using 

filter: invert(1) hue-rotate(180deg);

Could you help me with these issues @markerikson ?

markerikson commented 4 years ago

@ruppysuppy : as I said above, the right answer here is to migrate our docs to Docusaurus v2. If you'd like to work on that I'd really appreciate it, but no, a CSS hack like that is not the approach we need.

You can see our DSv2 setups for Redux Toolkit and the Redux core in their repos, like https://github.com/reduxjs/redux-toolkit/tree/master/website . The biggest issue with doing it for React-Redux is how the docs versioning gets handled.

ruppysuppy commented 4 years ago

@markerikson, I would like to give it a try, but it might take a couple of days as I would have to go through Docusaurus docs

ruppysuppy commented 4 years ago

@markerikson, I am unable to do it. The versioning does complicate it in Docusaurus 2.

markerikson commented 4 years ago

We upgraded to DSv2 in #1638 , so this is available now!