reduxjs / react-redux

Official React bindings for Redux
https://react-redux.js.org
MIT License
23.38k stars 3.36k forks source link

[5.1.0-test.1] Connected components don't re render after state update #965

Closed ematipico closed 6 years ago

ematipico commented 6 years ago

I gave a first try to the new beta and I can see some problems (unless I should make some changes).

The components that are connected to the store via connect don't get updated (they don't re render). While debugging I can see that the function mapStateToProps gets called correctly (and I can see the changes) after the action but the component doesn't re-render hence it doesn't show the new values.

I hope it could help

ifiokjr commented 6 years ago

@markerikson Could a note of the fact that 5.1.0-test.1 is broken be added to the releases description.

Currently, it looks like it's encouraging usage.

image

I eagerly upgraded, only to find that it did, in fact, break everything 😄

markerikson commented 6 years ago

Hmm. Good point. Let's see..

Oh hey, you CAN edit release notes after the fact. Okay, will do. Thanks for the notice!