Possible richer ConnectResponse type in '@redux-devtools/extension'

reduxjs / redux-devtools

DevTools for Redux with hot reloading, action replay, and customizable UI

http://youtube.com/watch?v=xsSnOQynTHs

MIT License

13.99k stars 1.16k forks source link

Possible richer ConnectResponse type in '@redux-devtools/extension' #1097

Open dai-shi opened 2 years ago

dai-shi commented 2 years ago

Can ConnectResponse in '@redux-devtools/extension'

https://github.com/reduxjs/redux-devtools/blob/b82de745928211cd9b7daa7a61b197ad9e11ec36/packages/redux-devtools-extension/src/index.ts#L187-L190

be compatible with or imported from

https://github.com/reduxjs/redux-devtools/blob/b82de745928211cd9b7daa7a61b197ad9e11ec36/extension/src/app/api/index.ts#L522-L536

which seems more precise?

Methuselah96 commented 2 years ago

Yes, good catch. Ideally we would share all the types, but I'm not sure how straightforward that will be. Feel free to open a PR to update them and/or share them. I'll try to get to around to it myself when I get a chance if you don't have time.