search

reduxjs / redux-devtools

DevTools for Redux with hot reloading, action replay, and customizable UI
http://youtube.com/watch?v=xsSnOQynTHs
MIT License
13.96k stars 1.15k forks source link

Adds argument to prevent Redux DevTool CLI disconnecting when debugging #1622

Open jardicc opened 4 months ago

jardicc commented 4 months ago

Adds new CLI argument to change pingTimeout value. This solves few issues for me if I set crazy high number.

1) UXP in Photoshop has UWP implementation of WebSockets and its client when asked to send empty message it is never sent but everything else is. Thefore it gets disconnected. https://github.com/reduxjs/redux-devtools/issues/1614

2) I think for some older middleware using protocol V1 sending different ping content this could help as well https://github.com/zalmoxisus/remote-redux-devtools/issues/158

3) When you debug client app and you stop on breakpoint for 20s which default value of socket cluster... it will disconnect debugger as well because you stopped client app so it can't send a ping. So value can be increased to prevent that.

Also maxRequestBody was wrong.

Please let me know if I should change something or feel free to change it yourself. I was thinking about seconds instead of ms but not sure what is better.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: c4f82c008528341f5fd488903ace39fcc481820c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR